From ea6dae9a30893632d863ff664803e17f3e9965f6 Mon Sep 17 00:00:00 2001 From: tooptoop4 <33283496+tooptoop4@users.noreply.github.com> Date: Sun, 20 Oct 2024 02:45:12 +1100 Subject: [PATCH] fix(ui): clarify log deletion in log-viewer. Fixes #10993 (#13788) Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> --- .../components/workflow-logs-viewer/workflow-logs-viewer.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx b/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx index 1f7c5b831cd2..7f558e93d583 100644 --- a/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx +++ b/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx @@ -289,11 +289,12 @@ export function WorkflowLogsViewer({workflow, initialNodeId, initialPodName, con )} {execSpec(workflow).podGC && ( <> - Your pod GC settings will delete pods and their logs{' '} + Your pod GC settings will delete pods{' '} {execSpec(workflow).podGC.deleteDelayDuration ? `after ${execSpec(workflow).podGC.deleteDelayDuration}` : 'immediately'} on completion. )}{' '} - Logs may not appear for pods that are deleted.{' '} + Logs may not appear for pods that are deleted unless you have archive logs{' '} + enabled.{' '} {podName ? (