-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move basic auth for for Azure DevOps to webhooks lib #19407
feat: move basic auth for for Azure DevOps to webhooks lib #19407
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Is there any testing we can/should have here? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19407 +/- ##
==========================================
+ Coverage 52.84% 52.85% +0.01%
==========================================
Files 316 316
Lines 43656 43636 -20
==========================================
- Hits 23069 23065 -4
+ Misses 18032 18020 -12
+ Partials 2555 2551 -4 ☔ View full report in Codecov by Sentry. |
84a3ea0
to
c4cf564
Compare
@crenshaw-dev tests for basic auth in Azure DevOps (and secrets for other SCM providers) are already included in the lib. Not sure if it's required in that case. Do you have anything specific in mind? |
Signed-off-by: Robin Lieb <[email protected]>
c4cf564
to
d32649c
Compare
…19407) Signed-off-by: Robin Lieb <[email protected]> Signed-off-by: Ilia Medvedev <[email protected]>
…19407) Signed-off-by: Robin Lieb <[email protected]>
Basic auth for Azure Webhooks was added to the webhooks library in this PR: go-playground/webhooks#191
Which was released with version 6.4.0: https://github.com/go-playground/webhooks/releases/tag/v6.4.0
This change removes the basic auth check for Azure DevOps to remove complexity since this is now included in the underlying library.
Checklist: