Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd parcel optimization skips certain scripts #571

Open
hi-liang opened this issue Aug 9, 2023 · 0 comments
Open

Odd parcel optimization skips certain scripts #571

hi-liang opened this issue Aug 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@hi-liang
Copy link
Member

hi-liang commented Aug 9, 2023

The CV pipeline for XR Browser broke and upon debug, it appears that the Base64Binary.js import in the WebARViewerCameraCapture class gets omitted by possibly some weird treeshaking/optimization.

This was resolved crudely in 976c43f but there is no obvious reason why the call here

const byteArray = Base64Binary.decodeArrayBuffer(frame._buffers[this.buffIndex]._buffer);

is not sufficient

Something to keep an eye on in case other functions or imports start disappearing into the ether

@hi-liang hi-liang added the bug Something isn't working label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant