Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support object grabbing #530

Open
EdwardLu2018 opened this issue Apr 26, 2023 · 8 comments
Open

Support object grabbing #530

EdwardLu2018 opened this issue Apr 26, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@EdwardLu2018
Copy link
Member

Would be great to have a way to grab and drag objects like super hands has. Needs to be done in a distributed manner, however.

Maybe whenever a user grabs an object, it will constantly publish its world position every 10 Hz?

@EdwardLu2018 EdwardLu2018 added the enhancement New feature or request label Apr 26, 2023
@hi-liang
Copy link
Member

hi-liang commented Apr 26, 2023

We need a new clientEvent grab-start or somesuch.

Just childs the object to grabber, based on the initial offset between them (will keep it pose-locked to hand)

More important part is other clients validating that the object being grabbed is a grabbable and some other stuff, as this would otherwise result in some violation of our objectId-vs-topic checks

@hi-liang
Copy link
Member

Actually that's still a problem when you release, because non-editor users still can't write the new (stationary) position of the grabbable object.

Maybe persist needs to special case the grab-end message and allow it to update pos/rot only in persist

@mwfarb
Copy link
Contributor

mwfarb commented May 26, 2023

Joey has done some work on this, this week.

  • Preliminary tests publishing any controller button/stick events.
  • Preliminary tests with a Python program consuming those events and deciding how to simulate a grab.

@mwfarb
Copy link
Contributor

mwfarb commented May 26, 2023

It would be good to decide if this is an:

  • A-frame side natural parenting.
  • A Python app.

@mwfarb
Copy link
Contributor

mwfarb commented May 26, 2023

Would be great to have a way to grab and drag objects like super hands has. Needs to be done in a distributed manner, however.

Maybe whenever a user grabs an object, it will constantly publish its world position every 10 Hz?

If the object is a child of the hand, the existing 10Hz parent publish should take care of this.

@EdwardLu2018
Copy link
Member Author

Huh, parents handle publishing pose of children? I didn't know that...

@EdwardLu2018
Copy link
Member Author

Related to #532

@hi-liang
Copy link
Member

This is partially supported "natively" in AFRAME from v1.5.0.

Does not of course, address network publishing, persist updating, or state conflicts of grabbed or graber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants