-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Twitter card for profiles #1793
Comments
Ah when I looked at this I assumed we didn't have images for profiles. Yes I would write a custom node and return a single image for it. Why not avatar though? |
Can you check if twitter cards invoke client-side code? |
Does not appear so: https://twittercommunity.com/t/support-for-dynamically-added-meta-tags/62862/3 |
More context here: nfl/react-helmet#26 |
Right that's fine. I'd just add a node and add it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On jade rendered routes, we currently automatically populate twitter cards for the given page:
ervell/components/meta/templates/meta.jade
Line 37 in 37483bc
After switching to React rendered profiles, these tags are no longer present. Check for cards here: https://cards-dev.twitter.com/validator
After looking into this for ten minutes, I actually thought it would be preferable to make a field specifically for this in GraphQL (i.e.
meta_images
that would just return an array of images from the given profile.Something else to consider is only rendering these meta tags for social bot / agents: https://stackoverflow.com/questions/29261733/detect-social-bots-in-node-express
The text was updated successfully, but these errors were encountered: