Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP version support #131

Open
fruitl00p opened this issue Apr 24, 2024 · 0 comments
Open

PHP version support #131

fruitl00p opened this issue Apr 24, 2024 · 0 comments

Comments

@fruitl00p
Copy link
Contributor

Currently the supported version of PHP in composer.json states "^7.3|^8.0|^8.1" But in the 1.x branch in src/Traits/Helpers.php there's a trailing , in the runProcessInBlast which is only supported since PHP8+
As 7.3 is already was past its EOL, I'd like to propose and drop EOL versions (which does require a semver major bump)

What are your thoughts? It would currently break on PHP7 anyway, and i'd like to contribute some PHP8+ cleanup (return types, property types et al)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant