Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] Object at path is not a service constructor (only last added grpc service is ran correctly) #7962

Closed
1 of 4 tasks
Justin-Booij opened this issue Nov 19, 2024 · 3 comments · Fixed by #8203
Closed
1 of 4 tasks

[V1] Object at path is not a service constructor (only last added grpc service is ran correctly) #7962

Justin-Booij opened this issue Nov 19, 2024 · 3 comments · Fixed by #8203

Comments

@Justin-Booij
Copy link

Justin-Booij commented Nov 19, 2024 •
edited
Loading

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

Make sure to fork this template and run yarn generate in the terminal.

Please make sure Mesh package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

graphql-mesh will only run the last, alphabetical, service correctly in v1 for GRPC services. Any other service will error with the message Object at path xx.xxService is not a Service constructor

To Reproduce Steps to reproduce the behavior:

see: reproduction repository

  1. start store-api and pet-api using node node api.js f.e on both api's
  2. run npm run start in the main directory
  3. go to localhost:4000/graphql
  4. Try doing both GetAllPets and GetAllPetStores, this will return all petstores but error on petservice
  5. Rename the "Stores" service in mesh.config.ts to "AStores"
  6. restart & rebuild the mesh service
  7. retry step 4, this time the petstore will error with the same message

Expected behavior

Every grpc service to properly be approachable through graphql-mesh

Environment:

  • OS: Linux fedora & docker (linux)
    -Packages:
    "@graphql-hive/gateway": "^1.4.10",
    "@graphql-mesh/compose-cli": "^1.1.9",
    "@graphql-mesh/transport-grpc": "^0.0.1",
    "@omnigraph/grpc": "^0.1.1",
    "@omnigraph/openapi": "^0.107.5",
  • Grpc (both using node server and c# servers
@iamchanii
Copy link
Contributor

I made a reproduction branch: https://github.com/iamchanii/graphql-mesh/tree/issue-7962-failing-test
just update e2e/grpc-example tests: Add pets grpc service and add it into mesh config.

Sorry for ping, @ardatan can you check this issue? I've run into this problem too, and it's the biggest issue preventing adoption

@NickMele
Copy link
Contributor

We are also running into this same exact issue. It is blocking our ability to upgrade from v0 to v1 of GraphQL Mesh. I don't have much more to add since the test @iamchanii put together represents the exact issue we are seeing.

@iamchanii
Copy link
Contributor

iamchanii commented Dec 28, 2024 •
edited
Loading

After a few hours of debugging, here's what I found:

  • In getDescriptorSets from ommigraph/grpc, there is a logic to determine the name of grpcRootJson directive. if root.name is not defined, make new a name using index. but it is not appropriate to use as a unique value when there are more than two subgraphs. This results in two subgraphs with the same root name.
  • In getStitchedSchemaFromSupergraphSdl from graphql-hive/gateway, this is why there is only one grpcRootJson directive for the supergraph Query type. grpcRootJson directive is repeatable, but when calling the mergeDirective function, do not pass a directives argument that contains the grpcRootJson directive.

@iamchanii iamchanii mentioned this issue Dec 28, 2024
Closed
9 tasks
@ardatan ardatan mentioned this issue Dec 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix multiple gRPC subgraphs in a supergraph ardatan/graphql-mesh
3 participants
@NickMele @iamchanii @Justin-Booij