Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODATA query parameters not url-encoded #6986

Open
4 tasks
WichardRiezebos opened this issue May 17, 2024 · 1 comment
Open
4 tasks

ODATA query parameters not url-encoded #6986

WichardRiezebos opened this issue May 17, 2024 · 1 comment

Comments

@WichardRiezebos
Copy link

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

Make sure to fork this template and run yarn generate in the terminal.

Please make sure Mesh package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

When using OData with query parameters, the query parameters are not url-encoded. This worked last week?

* STATE: INIT => CONNECT handle 0x14104be08; line 1879 (connection #-5000)
* curl_url_set rejected https://api.server.nl/OData/V1/projects?$filter=Number eq '1234'&$select=Id,Description: Bad query
* Closing connection -1

To Reproduce Steps to reproduce the behavior:

Expected behavior

Do a curl with url-encoded parameters.

Environment:

  • OS:
  • @graphql-mesh/odata:
  • NodeJS:

everything latest version

Additional context

@ardatan
Copy link
Owner

ardatan commented Nov 6, 2024

We no longer use curl and query params should automatically be encoded by the client.
Could you update to the latest version and try again?
Thanks and sorry for the late response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants