Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vex): suppress CVE-2024-45338 #8137

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Dec 19, 2024

Description

govulncheck confirmed it doesn't affect Trivy.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Dec 19, 2024
@knqyf263 knqyf263 marked this pull request as ready for review December 20, 2024 06:10
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small question:
We can fix this vulnerability (see #8140)
But you also want to add this VEX file for users using non-latest version of Trivy so they can suppress this vulnerability, right?

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Dec 20, 2024

But you also want to add this VEX file for users using non-latest version of Trivy so they can suppress this vulnerability, right?

Yes. If a vulnerability doesn't affect Trivy, we should state it in VEX so that users will not worry about it. Otherwise, users will try to bump Trivy in a hurry, but it's unnecessary.

@knqyf263 knqyf263 added this pull request to the merge queue Dec 20, 2024
Merged via the queue into aquasecurity:main with commit 95f7a56 Dec 20, 2024
13 checks passed
@knqyf263 knqyf263 deleted the vex/cve_2024_45338 branch December 20, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants