Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(license): trim leading and trailing spaces for licenses #8094

Closed
DmitriyLewen opened this issue Dec 13, 2024 Discussed in #8086 · 0 comments · Fixed by #8095
Closed

bug(license): trim leading and trailing spaces for licenses #8094

DmitriyLewen opened this issue Dec 13, 2024 Discussed in #8086 · 0 comments · Fixed by #8095
Assignees
@DmitriyLewen
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/license Issues relating to license scanning
Milestone
v0.59.0

Comments

@DmitriyLewen
Copy link
Contributor

Description

We trim leading and trailing spaces for licenses in table format:

┌─────────────────────────────┬─────────────────────────────────────────────────────┬────────────────┬──────────┐
│           Package           │                       License                       │ Classification │ Severity │
├─────────────────────────────┼─────────────────────────────────────────────────────┼────────────────┼──────────┤
│ org.jvnet.staxex:stax-ex    │ Dual license consisting of the CDDL v1.1 and GPL v2 │ Forbidden      │ CRITICAL │
├─────────────────────────────┼─────────────────────────────────────────────────────┼────────────────┼──────────┤
│ javax.activation:activation │ CDDL-1.0                                            │ Reciprocal     │ MEDIUM   │
└─────────────────────────────┴─────────────────────────────────────────────────────┴────────────────┴──────────┘

But json format contains spaces:

          "Name": "\n                Dual license consisting of the CDDL v1.1 and GPL v2\n            ",

I think we should use the same logic for all reports.
Also causes problems with license setup (see #8086)

Discussed in #8086
@DmitriyLewen DmitriyLewen added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. scan/license Issues relating to license scanning labels Dec 13, 2024
@DmitriyLewen DmitriyLewen self-assigned this Dec 13, 2024
@DmitriyLewen DmitriyLewen added kind/bug Categorizes issue or PR as related to a bug. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Dec 13, 2024
@DmitriyLewen DmitriyLewen changed the title enhancement(license): trim leading and trailing spaces for licenses bug(license): trim leading and trailing spaces for licenses Dec 13, 2024
@DmitriyLewen DmitriyLewen mentioned this issue Dec 13, 2024
Merged
6 tasks
@DmitriyLewen DmitriyLewen added this to the v0.59.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriyLewen DmitriyLewen

Labels
kind/bug Categorizes issue or PR as related to a bug. scan/license Issues relating to license scanning
Projects
None yet
Milestone
v0.59.0
Development

Successfully merging a pull request may close this issue.

fix(license): always trim leading and trailing spaces for licenses DmitriyLewen/trivy
1 participant
@DmitriyLewen