Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle BLOW_UNKNOWN error to download DBs #8060

Merged

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Dec 6, 2024

Description

We found that GCR periodically returns BLOW_UNKNOWN error - #8020
We assume that this is related to their cache.

But in any case, we need to handle this error and check other repositories if loading a repository returns BLOW_UNKNOWN error.

Issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Dec 6, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review December 6, 2024 06:49
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@knqyf263 knqyf263 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into aquasecurity:main with commit 51f2123 Dec 6, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/handle-blob-unknown-error branch December 6, 2024 09:18
@knqyf263
Copy link
Collaborator

knqyf263 commented Dec 9, 2024

@DmitriyLewen Do you think we should cut v0.58.1?

@DmitriyLewen
Copy link
Contributor Author

Are there any other critical fixes?
It seems this bug is not very common and we may include this fix in v0.59.0.

But overall for the user experience we may cut v0.58.1

@knqyf263
Copy link
Collaborator

knqyf263 commented Dec 9, 2024

I don't see any other hotfixes. If we receive more reports of this error, we can cut v0.58.1.

@DmitriyLewen
Copy link
Contributor Author

Yes, let's get more feedback from users.

@marcoschmidl
Copy link

marcoschmidl commented Dec 13, 2024

Hey, I would really appreciate the 0.58.1 with the bug fix for the BLOB_UNKNOWN error. In my current project, I use Trivy for AKS and run it in a GitLab pipeline. In the past two weeks, I had the error a few times. The new release with the fix would be a quick solution without further workarounds.

@knqyf263
Copy link
Collaborator

You can track the milestone here.
https://github.com/aquasecurity/trivy/milestone/45

@DmitriyLewen
Copy link
Contributor Author

Hello @marcoschmidl
Trivy has canary builds.
If you really need this fix - you can use this - https://github.com/aquasecurity/trivy/actions/runs/12195096688

@DmitriyLewen
Copy link
Contributor Author

@aqua-bot backport release/v0.58

@aqua-bot
Copy link
Contributor

Backport PR created: #8121

@marcoschmidl
Copy link

Thanks for your support @DmitriyLewen @knqyf263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fall back repositories with BLOB_UNKNOWN errors
4 participants