Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yarn): add workspace as dependencies and use workspace relationship for them #8012

Open
DmitriyLewen opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@DmitriyLewen
Copy link
Contributor

DmitriyLewen commented Nov 29, 2024

Description

We currently don't expose workspace as separate packages (only define direct and indirect dependencies on them).

After #7889 we can add them with the workspace relationship.

Required changes:

  • detect workspace packages from path/to/workspace/package.json files.
  • use workspace relationship for these packages
  • add relationships between workspaces and direct packages of workspaces.
  • ??? detect project id from root package.json file to add root package (@knqyf263 wdyt?) and add workspaces as dependencies of root package
@DmitriyLewen DmitriyLewen added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2024
@DmitriyLewen DmitriyLewen added this to the v0.60.0 milestone Nov 29, 2024
@DmitriyLewen DmitriyLewen self-assigned this Nov 29, 2024
@knqyf263
Copy link
Collaborator

??? detect project id from root package.json file to add root package (@knqyf263 wdyt?) and add workspaces as dependencies of root package

Yes, we should do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants