-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sbom): scan results of SBOMs generated from container images are missing layers #7635
Merged
knqyf263
merged 3 commits into
aquasecurity:main
from
fabriziosestito:fix/scan-from-containers-sbom-missing-layers
Dec 11, 2024
Merged
fix(sbom): scan results of SBOMs generated from container images are missing layers #7635
knqyf263
merged 3 commits into
aquasecurity:main
from
fabriziosestito:fix/scan-from-containers-sbom-missing-layers
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
requested review from
knqyf263 and
DmitriyLewen
as code owners
October 2, 2024 12:20
fabriziosestito
changed the title
fix(scanner): scan results of SBOMs generated from container images are missing layers
fix(sbom): scan results of SBOMs generated from container images are missing layers
Oct 2, 2024
…missing layers Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
fix/scan-from-containers-sbom-missing-layers
branch
from
October 2, 2024 12:21
0205c55
to
845bfb8
Compare
Thanks for your contribution. Could you fix tests? |
Signed-off-by: Fabrizio Sestito <[email protected]>
@DmitriyLewen Would you also take a look? |
DmitriyLewen
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, but couldn't think of a issues for these changes 😄
Approved.
cc. @knqyf263
…om-containers-sbom-missing-layers
knqyf263
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When scanning a SBOM generated from a container image, layers are missing from the scan results.
This happens because layers are explicitly removed if the scanned artifact is not of the type container image.
However, this removes the layers when a container image SBOM is generated from a container image.
Moreover, setting layers to an empty value is not needed as layers are not present when scanning artifacts that are not container images or SBOMs of container images anyway.
Related issues
Checklist