Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delete db mock #6940

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Conversation

knqyf263
Copy link
Collaborator

Description

We already use FakeImage for DB tests in most places, and only pkg/rpc/server/listen_test.go is using mock now. This PR migrates the test to FakeImage and deletes the DB mock.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Jun 14, 2024
@knqyf263 knqyf263 requested a review from DmitriyLewen as a code owner June 14, 2024 12:16
Signed-off-by: knqyf263 <[email protected]>
@knqyf263 knqyf263 force-pushed the refactor/delete_db_mock branch from 88ec394 to f8590f2 Compare June 19, 2024 07:01
@knqyf263
Copy link
Collaborator Author

@DmitriyLewen It's ready for review now.

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into aquasecurity:main with commit e493fc9 Jun 20, 2024
12 checks passed
@knqyf263 knqyf263 deleted the refactor/delete_db_mock branch June 20, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants