Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include k8s add-ons in kbom #5175

Closed
chen-keinan opened this issue Sep 13, 2023 · 6 comments · Fixed by #5178
Closed

include k8s add-ons in kbom #5175

chen-keinan opened this issue Sep 13, 2023 · 6 comments · Fixed by #5178
Assignees
@chen-keinan
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning
Milestone
v0.45.1

Comments

@chen-keinan
Copy link
Contributor

chen-keinan commented Sep 13, 2023 •
edited
Loading

it is require to add to include all k8s add-ons with in kbom
every resource which has label the `k8s-app: in all namespaces.

this change enable trivy to include Container Network Interface (CNI) with in kbom

  • Flannel
  • Calico
  • Cilium
@chen-keinan chen-keinan added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning labels Sep 13, 2023
@chen-keinan chen-keinan self-assigned this Sep 13, 2023
@chen-keinan chen-keinan changed the title support kbom addon cni and other support kbom add-ons Sep 13, 2023
@chen-keinan chen-keinan changed the title support kbom add-ons include k8s add-ons in kbom Sep 13, 2023
This was referenced Sep 13, 2023
Merged
Merged
Merged
@chen-keinan chen-keinan added this to the v0.45.1 milestone Sep 13, 2023
@chen-keinan
Copy link
Contributor Author

@knqyf263 I have marked it for milestone v0.45.1 if you think it can't make then move it to v0.46.0

@knqyf263
Copy link
Collaborator

Is it a bug fix? v0.45.1 is supposed to include bug fixes only.

@knqyf263
Copy link
Collaborator

@chen-keinan Ping just in case you missed my response.

@chen-keinan
Copy link
Contributor Author

chen-keinan commented Sep 14, 2023 •
edited
Loading

Is it a bug fix? v0.45.1 is supposed to include bug fixes only.
@knqyf263
yes, its include a bug fix and a very small change to collect pods info from all namespaces and not just kube-system

@knqyf263
Copy link
Collaborator

But this PR is labeled as a feature enhancement. Are you changing it to fix(k8s):?
#5178

@chen-keinan chen-keinan added kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Sep 14, 2023
@chen-keinan
Copy link
Contributor Author

But this PR is labeled as a feature enhancement. Are you changing it to fix(k8s):? #5178

@knqyf263 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chen-keinan chen-keinan

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning
Projects
Trivy Roadmap
Archived in project
Milestone
v0.45.1
Development

Successfully merging a pull request may close this issue.

fix(k8s): kbom support addons labels chen-keinan/trivy
2 participants
@knqyf263 @chen-keinan