Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for parse-arguments #2177

Open
2 tasks
NDStrahilevitz opened this issue Sep 20, 2022 · 0 comments · May be fixed by #4086
Open
2 tasks

Remove need for parse-arguments #2177

NDStrahilevitz opened this issue Sep 20, 2022 · 0 comments · May be fixed by #4086

Comments

@NDStrahilevitz
Copy link
Collaborator

NDStrahilevitz commented Sep 20, 2022

Currently we require -o option:parse-arguments for signatures to function properly. This makes both the signatures and the event pipeline less efficient.

As a first step, let's remove argument parsing and use the raw arguments values in signatures.
This means we should update the golang signatures to use the libbpfgo consts and remove parse-arguments from being enabled by default with the pipeline. libbpfgo already have argument parsing helpers in a separate module so they can be used as enum values in signatures.

Next steps (not part of this issue) include:

@NDStrahilevitz NDStrahilevitz added this to the v0.9.0-rc1 milestone Sep 20, 2022
@NDStrahilevitz NDStrahilevitz self-assigned this Sep 20, 2022
@yanivagman yanivagman modified the milestones: v0.9.0-rc1, v.0.10.0 Oct 26, 2022
@yanivagman yanivagman modified the milestones: v0.10.0, v0.11.0 Nov 22, 2022
@yanivagman yanivagman changed the title [REFAC] Remove need for parse-arguments Remove need for parse-arguments Jan 2, 2023
@NDStrahilevitz NDStrahilevitz modified the milestones: v0.11.0, v0.12.0 Jan 24, 2023
@NDStrahilevitz NDStrahilevitz modified the milestones: v0.12.0, v0.14.0 Feb 15, 2023
@NDStrahilevitz NDStrahilevitz modified the milestones: v0.14.0, v0.15.0 May 2, 2023
@geyslan geyslan mentioned this issue May 26, 2023
@rafaeldtinoco rafaeldtinoco modified the milestones: v0.15.0, v0.16.0 May 27, 2023
@yanivagman yanivagman modified the milestones: v0.16.0, v0.17.0 Jun 21, 2023
@geyslan geyslan modified the milestones: v0.17.0, v0.18.0 Jul 25, 2023
@yanivagman yanivagman removed this from the v0.18.0 milestone Aug 16, 2023
@yanivagman yanivagman modified the milestones: v0.21.0, v0.22.0 May 16, 2024
@NDStrahilevitz NDStrahilevitz linked a pull request May 29, 2024 that will close this issue
@yanivagman yanivagman modified the milestones: v0.22.0, v0.23.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment