Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable images and videos to be shown as a lightbox when clicked. #23

Open
GiovanniSmokes opened this issue Aug 28, 2023 · 4 comments · May be fixed by #51
Open

Enable images and videos to be shown as a lightbox when clicked. #23

GiovanniSmokes opened this issue Aug 28, 2023 · 4 comments · May be fixed by #51

Comments

@GiovanniSmokes
Copy link
Contributor

No description provided.

@vporton
Copy link
Contributor

vporton commented Oct 10, 2023

Is this to magnify images/videos more big than they are now?

If yes, should the LightBox take the entire browser window? or even be fullscreen?

@GiovanniSmokes
Copy link
Contributor Author

Is this to magnify images/videos more big than they are now?

If yes, should the LightBox take the entire browser window? or even be fullscreen?

It doesn't have to be full screen, once its big enough. I guess a little bit under full screen would be ideal

@vporton
Copy link
Contributor

vporton commented Oct 10, 2023

What do we show as video preview? Or LightBox (I notify you that there are many other similar plugins, not worse than LightBox) will display a preview automatically? (not sure how to configure it for this)

@apssouza22
Copy link
Owner

Just use a simple lightbox effect with the real size of the image and a default video size

@vporton vporton linked a pull request Oct 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants