Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

independent utility to write metadata file after the run completes #107

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

independent utility to write metadata file after the run completes #107

wants to merge 3 commits into from

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Nov 6, 2024

@prjemian prjemian added the enhancement New feature or request label Nov 6, 2024
@prjemian prjemian self-assigned this Nov 6, 2024
MDecarabas
MDecarabas reviewed Nov 6, 2024
View reviewed changes
src/instrument/utils/conversions.py Show resolved Hide resolved
src/instrument/utils/dm_metadata_file.py Outdated Show resolved Hide resolved
src/instrument/utils/dm_metadata_file.py
from .iconfig_loader import iconfig # noqa

CATALOG = iconfig.get("DATABROKER_CATALOG", "8idi_xpcs")
XPCS_LAYOUT_VERSION = "APS-8IDI-202310"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this showcase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XPCS_LAYOUT_VERSION is for the consumer of this file, to expect that certain items are present.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, is there anywhere for users to see what layout versions are expected and the options one could use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a conversation with @AZjk .

@prjemian prjemian mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDecarabas MDecarabas MDecarabas left review comments

@sureshnaps sureshnaps Awaiting requested review from sureshnaps

@qzhang234 qzhang234 Awaiting requested review from qzhang234

Assignees

@prjemian prjemian

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Independent function for writing the nx hdf file after acquisition is complete
2 participants
@prjemian @MDecarabas