Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging morphounit and NeuronUnit's morphology.py #4

Open
rgerkin opened this issue Jul 17, 2019 · 4 comments
Open

Merging morphounit and NeuronUnit's morphology.py #4

rgerkin opened this issue Jul 17, 2019 · 4 comments

Comments

@rgerkin
Copy link

rgerkin commented Jul 17, 2019

@appukuttan-shailesh @pedroernesto
@JustasB from my lab put together some morphology tests of his own here, which have many similarities to yours. His are based on the original L-Measure, and the accompanying python package pyLMeasure.

Can we discuss possibly merging this and morphounit?

@pedroernesto
Copy link
Collaborator

pedroernesto commented Jul 18, 2019

For now, what I see is that some features being tested by means of pyLMeasure maybe do not exist in NeuroM, which is the API we use in MorphoUnit. So, both lines of work may complement each other. I would suggest to discuss this issue with Andrew probably next week, when he is back.

Btw, I have to upload my last work on morphounit to this original repository, which I did on March-April following a Sailesh's hint, with the aim to keep MorphoUnit more generic. The work is in my forked repository: https://github.com/pedroernesto/morphounit

The most recent improvements can be summarized as follows:

  • Checks the compliance of the raw observation file with NeuroM's (fst module) nomenclature.
  • Automatic creation of configuration files for morph_stats and NeuroM, from that raw observation file.
  • Deletes some neurite's morphometrics added by morph_stats, but not present in the observation file.
  • Reversed to plural the number in feature names generated by morph_stats in the prediction file, to make it compatible with the observation file.
  • Added more features that can be specified in the observation file. They can now be generated in the prediction file by means of other NeuroM modules than morph_stats, e.g. field diameter, bounding-box -X,Y,Z- extents and -largest,shortest- principal extents

@appukuttan-shailesh
Copy link
Owner

Interesting to see this as just yesterday I was updating the MorphoUnit usecase.

@rgerkin : For sure it would be nice to have them merged into a single package. We could maybe take this up during our next video call (Monday, 29th July)?

@pedroernesto : Yesterday I had made a pull request to merge your most recent changes into the repo and have a new release (for employing in the usecase). I intend to get it done today.

@rgerkin
Copy link
Author

rgerkin commented Jul 22, 2019

Sounds good. We'll discuss this at the 7/29 meeting.

@rgerkin
Copy link
Author

rgerkin commented Dec 9, 2019

I added this to the Slack message from several months ago (which I missed until now), but the full list of L-measure features is shown here in the left-hand column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants