-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inline editing test case in TableV2 #36697
base: pg
Are you sure you want to change the base?
Conversation
The inline editing test case in TableV2 was failing due to an incorrect assertion. This commit fixes the test case by updating the assertion to match the expected result.
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/ci-test-limit-count run_count=15 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11175018536. |
/ci-test-limit-count run_count=15 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11177061470. |
/ci-test-limit-count run_count=15 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11178260654. |
Failed server tests
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11178260654.
|
/ci-test-limit |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11209160229. |
Failed server tests
|
/ci-test-limit runId=11209160229 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11209442186. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11209442186. |
Failed server tests
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11209707439. |
/ci-test-limit runId=11209160229 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11209717871. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11209717871. |
Failed server tests
|
/ci-test-limit-count run_count=15 runId=11209160229 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11210109040. |
/ci-test-limit runId=11209160229 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11210296368. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11210296368. |
/ci-test-limit-count run_count=15 runId=11209160229 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11210453305. |
Failed server tests
|
Description
This pull request fixes the inline editing test case in TableV2.
The test case was failing due to an incorrect assertion, so this commit updates the assertion to match the expected result.
Additionally, the limited-tests.txt file is updated to include the TableV2 inline editing test case.
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Table"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11210291429
Commit: ab03e73
Cypress dashboard.
Tags:
@tag.Table
Spec:
Mon, 07 Oct 2024 08:00:59 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?