Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Changing Modal name does not change its references even after the Modal1.name code refactor #34823

Closed
1 task done
tomjose92 opened this issue Jul 9, 2024 · 0 comments · Fixed by #34855
Closed
1 task done
Assignees
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Entity Refactor Issues related to refactor logic FE Coders Pod Issues related to users writing javascript in appsmith Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention

Comments

@tomjose92
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

Hi Team,
I can see the recent changes to move away from using Modal name as string, and instead using an attribute of the Modal widget, eg Modal1.name
But i still face issues after renaming the Modal name. All the widgets or code that is using Modal1.name is not changing to the name Modal widget name, something like Test_Modal.name

Screenshot 2024-07-09 at 4 29 45 PM

Steps To Reproduce

  1. Drag and Drop a button
  2. Configure its onClick action to showModal and create new Modal
  3. Change modal's name from Modal1 to some other name like "Test_Modal"
  4. Now try to close the Modal using the Close button or icon.
  5. An error will be shown saying could not find Modal1

On inspecting either of the close button's onClick event, you will see that the reference is still to closeModal(Modal1.name)
and not closeModal(Test_Modal.name)

With the refactor changes done to use Modal.name instead of string, the references should have been changed all across.
But that does not seem to be happening

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

Cloud

@tomjose92 tomjose92 added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Integrations Pod Issues related to a specific integration labels Jul 9, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow Production labels Jul 9, 2024
@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data and removed Integrations Pod Issues related to a specific integration labels Jul 9, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Entity Refactor Issues related to refactor logic and removed BE Coders Pod Issues related to users writing code to fetch and update data labels Jul 9, 2024
@github-actions github-actions bot added the FE Coders Pod Issues related to users writing javascript in appsmith label Jul 9, 2024
@AmanAgarwal041 AmanAgarwal041 added the Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. label Jul 10, 2024
@github-actions github-actions bot added the Integrations Pod Issues related to a specific integration label Jul 10, 2024
@appsmith-bot appsmith-bot added the QA Needs QA attention label Jul 12, 2024
@github-actions github-actions bot added BE Coders Pod Issues related to users writing code to fetch and update data QA Pod Issues under the QA Pod labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Entity Refactor Issues related to refactor logic FE Coders Pod Issues related to users writing javascript in appsmith Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants