[Bug]: Changing Modal name does not change its references even after the Modal1.name code refactor #34823
Closed
1 task done
Labels
BE Coders Pod
Issues related to users writing code to fetch and update data
Bug
Something isn't working
Entity Refactor
Issues related to refactor logic
FE Coders Pod
Issues related to users writing javascript in appsmith
Integrations Pod General
Issues related to the Integrations Pod that don't fit into other tags.
Integrations Pod
Issues related to a specific integration
Low
An issue that is neither critical nor breaks a user flow
Needs Triaging
Needs attention from maintainers to triage
Production
QA Pod
Issues under the QA Pod
QA
Needs QA attention
Is there an existing issue for this?
Description
Hi Team,
I can see the recent changes to move away from using Modal name as string, and instead using an attribute of the Modal widget, eg Modal1.name
But i still face issues after renaming the Modal name. All the widgets or code that is using Modal1.name is not changing to the name Modal widget name, something like Test_Modal.name
Steps To Reproduce
On inspecting either of the close button's onClick event, you will see that the reference is still to closeModal(Modal1.name)
and not closeModal(Test_Modal.name)
With the refactor changes done to use Modal.name instead of string, the references should have been changed all across.
But that does not seem to be happening
Public Sample App
No response
Environment
Production
Severity
Low (Cosmetic UI issues)
Issue video log
No response
Version
Cloud
The text was updated successfully, but these errors were encountered: