Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill monthly metrics for site test fails #354

Open
johnbaldwin opened this issue May 29, 2021 · 0 comments
Open

Backfill monthly metrics for site test fails #354

johnbaldwin opened this issue May 29, 2021 · 0 comments
Labels

Comments

@johnbaldwin
Copy link
Contributor

johnbaldwin commented May 29, 2021

Figures tests/test_backfill.py::test_backfill_monthly_metrics_for_site fails because the number of months expected to backfill do not match up. See the following:

>       backfilled = backfill_monthly_metrics_for_site(site=site, overwrite=True)
E       AssertionError: assert 6 == 5
E        +  where 6 = len([{'created': True, 'dt': datetime.datetime(2020, 11, 1, 0, 0, tzinfo=<UTC>), 'obj': <SiteMonthlyMetrics: id:1, month_f...ime(2021, 4, 1, 0, 0, tzinfo=<UTC>), 'obj': <SiteMonthlyMetrics: id:6, month_for:2021-04-01, site:site-3.example.com>}])
E        +  and   5 = len([{'month': datetime.datetime(2020, 11, 29, 13, 7, 24, tzinfo=<UTC>), 'month_sm': [<StudentModule: StudentModule object...entModule object>, <StudentModule: StudentModule object>, <StudentModule: StudentModule object>, ...], 'sm_count': 14}])

tests/test_backfill.py:104: AssertionError

This code is NOT run as part of normal daily or monthly pipeline job execution. Therefore, I'm marking the test with xfail to avoid this blocking Figures fixes for Juniper. We DO need to address it, but the purpose of this function and the Django management command that drives is is for backfilling MAU history for a new Figures deployment

xfail added to this test in this PR: #355

https://appsembler.atlassian.net/browse/RED-2173

johnbaldwin added a commit that referenced this issue May 29, 2021
This is for code that is run to backfill data on new deployments.

See: #354
bryanlandia added a commit that referenced this issue Jun 25, 2021
#354
has been resolved by prior fixes to previous months iterator
bryanlandia added a commit that referenced this issue Jun 28, 2021
#354
has been resolved by prior fixes to previous months iterator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant