-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Koa compatibility #323
Comments
Thanks for posting this, @mrtndwrd ! I look forward to seeing what you find |
OK, this was stupid... I forgot to add the
Now I only get a whole lot of these:
The data already includes almost everything I need. The only thing I notice is that on the "Overview" page the "Course enrollments" and "Course completions" metric stays at 0, probably due to the above error. |
The "Learners progress overview" page is also (still?) completely empty. Do I need to run another command to fill that? |
More detailed findings: I know that the following works:
What I know doesn't work:
|
Hey @mrtndwrd , I'm reading through your comments now. We've got Figures upgraded to Juniper and sandboxed in Juniper (but not yet in Juniper production) so there might still be a bug there. I'm a bit under schedule pressure right now, so can't put much time into helping, but will do the best I can. My apologies, but I may have to ask some naive questions of you because I've not yet worked with Tutor myself. This means that I'm now putting "test drive tutor figures" in my short list after I dig myself out of my current backlog. Starting points:
Hopefully I don't have a typo in the above On specific metrics: Any one of the following you want to explore first? A. "Course Completions" mean "Certificates generated" at this point in Figures life. We're planning on fixing this so that "course completions" means completed a threshold of sections in a course (which yeah, is a bit more vague than "Does learner have a cert? Y/N"). So it might be that B. Course details page - "Incorrect totals and percentages" - Any specific examples would be appreciated. Let's start with one. C. Learner Progress overview page is empty This page is going to be empty until terms are added to either the "Search by users name, username, email" or "Filter by courses" filters Have you tried either of these? Note: This may not work (so may be broken) as you mentioned that there are no course enrollments showing on the overview page |
i am using tutor 11.2.3 (koa) and getting the following error in the figure home page. webpack-stats.json. Are you sure webpack has generated the file and the path is correct |
@ashraf09091 how did you install Figures on your tutor setup? My original post mentions the
With this command you also use my fork of the Please note that I can't give you any warranty that following these instructions it will work. I'm still figuring out the bugs myself and I'm also unsure if our data even gets updated at the moment. |
@johnbaldwin thanks for your pointers! I'm sorry for being so slow in responding. I'll try to respond faster next time :)
I'm afraid not (at least not the learner data, courses I can share if it helps), we treat our learner's data with as much care as we can.
Yes:
Hmm, I know not a lot of our users actually generate the certificate, but there are more than 0 that choose to do so. Do you do any assumptions about how the certificate is generated? For example, all our courses are self-paced, so we have early certificates
For example, this is our overview page: Which shows 10 enrolled learners under "Access and Anonymity". When I click the course, though: It only shows 0 enrolled users. The second course I click shows an average course progress of 0%, but when I scroll down it shows 0% progress for some learners and 100% for others (sorry I can't paste a screenshot because I don't want to share our learners' data)
I found out that when the search succeeds, an error happens on the server:
This happens regardless of if I search for an (existing) user, or if I filter on a course. |
@mrtndwrd Just letting you know that I skimmed over your reply, and thanks for digging int the issue! I'll have to carve off some focus time. I did discover today that the learner progress overview page is not working right while running on the Figures devsite development server, so I have something else to look at to compare with what you posted. I also have to go back over completions. Aside from fixing what you observe, this is an area that really needs improvement, as you say "I know not a lot of our users actually generate the certificate". So, what does figures do now in brief? It grabs data that can have points earned via calling g the First it might help for me to document the current approach so it is clearer to everyone how figures does it now and maybe get feedback on ways to improve it, like going over the code here to see how it does it: https://github.com/edx/completion Grading and completion policy for figures is actually one of the top things that makes me want to enable plugins for Figures server side code. So Figures can provide a reasonable default on what "progress" means, what "completion" means and what "passing" means. And then anyone else can write a plugin/middleware to set their own rules |
FYI, when I try to upgrade to Lilac with Tutor 12, the build step seems to fail because Figures uses deprecated imports:
I think we'll have to stop trying to use Figures, because I don't have the time to fix this unfortunately. I'm curious, if you're at liberty to tell of course, does Appsembler not run Koa and Lilac? |
I second the questions of @mrtndwrd, if it's okay for you to answer, if there are plans to adapt Figure to Koa and Lilac. So, I've begun to debug (and understand the code of) Figures version build-0.4.dev14 with a local Koa instance using Derex. The first number not displaying correctly was the enrollments number, so I checked the Figure APpi end-point sending this data to the 'Overview' and 'Courses' pages. The end-point
which return an empty set. But if I remove the data range condition
I can get the table with the expected enrollments number (5 on my test koa instance):
It seems to me there is some problem in the date range specified on
The table I will continue debugging some other fields that seem to be wrong, like the completion data and some details' data from each course page. |
I'm taking a look at whether the current
0.4.dev8
version could already be (or be made) compatible with Koa.I'm pushing my work here and I'm using this fork of the tutor-figures plugin to install it on edX.
What works:
python manage.py lms populate_figures_metrics --no-delay
inside the LMS containerWhat doesn't work:
This is probably because when I run
python manage.py lms populate_figures_metrics --no-delay
this error occurs a lot of times:I assume this error happens for all the courses. I hope to be able to figure out why tomorrow. In the mean time, any advice would definitely help!
The text was updated successfully, but these errors were encountered: