Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some of our changes #5

Open
tkeemon opened this issue Mar 14, 2016 · 2 comments
Open

Remove some of our changes #5

tkeemon opened this issue Mar 14, 2016 · 2 comments

Comments

@tkeemon
Copy link

tkeemon commented Mar 14, 2016

These two changes:

can be removed from our version of the fork if we do the following in each customer's server-vars.yml file:


---
EDXAPP_APPSEMBLER_FEATURES: 
  FEATURE_1: value
  FEATURE_2: value

EDXAPP_ENV_EXTRA:
  APPSEMBLER_FEATURES: "{{ EDXAPP_APPSEMBLER_FEATURES }}"
@natea
Copy link

natea commented Mar 15, 2016

@tkeemon agreed that let's try to remove as many customizations from the playbooks as possible, and encapsulate them in server-vars.yml so they're all in one place.

@OmarIthawi
Copy link

Thanks TJ for the note. It's 2021 but not too late to address this tech debt. My tentative plan is to remove APPSEMBLER_FEATURES['ENABLE_XYZ'] in favor of settings.FEATUES['TAHOE_ENABLE_XYZ'].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants