Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TOML configuration reader scan for extension files #38

Open
ctrueden opened this issue Feb 7, 2024 · 3 comments
Open

Make TOML configuration reader scan for extension files #38

ctrueden opened this issue Feb 7, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ctrueden
Copy link
Member

ctrueden commented Feb 7, 2024

From this Zulip chat: a scenery/sciview use case requires the following --add-opens flags:

            "--add-opens=java.base/java.lang=ALL-UNNAMED",
            "--add-opens=java.base/java.lang.invoke=ALL-UNNAMED",
            "--add-opens=java.base/java.net=ALL-UNNAMED",
            "--add-opens=java.base/java.nio=ALL-UNNAMED",
            "--add-opens=java.base/java.time=ALL-UNNAMED",
            "--add-opens=java.base/java.util=ALL-UNNAMED",
            "--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED",
            "--add-opens=java.base/sun.nio.ch=ALL-UNNAMED",
            "--add-opens=java.base/sun.util.calendar=ALL-UNNAMED"

This is quite a few more packages than the ones configured in the current fiji.toml. And it highlights an important consideration: extensions to Fiji might need to augment the Jaunch configuration with additional flags.

A general way to address this, which would be compatible with the current ImageJ Updater, would be for Jaunch to look for additional files matching some convention, such as jaunch/fiji-x-*.toml, and load those as well. Then an update site could ship, say, jaunch/fiji-x-sciview.toml, with the additional --add-opens flags needed for that update site's functionality to behave properly with Java 17+.

@ctrueden ctrueden added the enhancement New feature or request label Feb 7, 2024
@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/jaunch-a-new-java-launcher-test-fiji-with-java-21/92058/1

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/jaunch-a-new-java-launcher-test-fiji-with-java-21/92058/55

@ctrueden
Copy link
Member Author

ctrueden commented May 3, 2024

With c5101c3, TOML files get sourced based on the primary TOML config file's includes line. To tackle this issue, we could simply allow wildcards in there, so that additional config files could be dropped in matching the pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants