Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect static analysis over union-with-default Mapping value types #62

Open
HT154 opened this issue Aug 22, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@HT154
Copy link

HT154 commented Aug 22, 2024

IntelliJ complains about code that is considered valid by pkl eval. Repro, with IntelliJ diags commented inline:

class Gizmo {
  name: String
}

x: Mapping<String, *Gizmo|Any> = new {
  ["a"] {
//      ^ Cannot amend value of type `Any`
    name = "hello"
  }
  ["c"] = new {
//        ^^^ Cannot instantiate type `Any`
    name = "goodbye"
  }
  ["c"] = 123
}

typealias GizmoAny = *Gizmo|Any

y: Mapping<String, GizmoAny> = new {
  ["a"] {
//      ^ Cannot amend value of type `GizmoAny`
    name = "hello"
  }
  ["c"] = new {
//        ^^^ Cannot instantiate type `GizmoAny`
    name = "goodbye"
  }
  ["c"] = 123
}
@bioball bioball added the bug Something isn't working label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants