-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription doesn't deduplicate #11864
Comments
Hello @Tainan404 - nice catch! I would like to add that consistently deduplicating the subscriptions is a very important feature for BigBlueButton. This feature allowed us to decouple the data consumption, allowing each component to require the data of interest. However, with this bug, we will eventually get duplicated subscriptions, increasing the load in both client and server. @jerelmiller - we have some workarounds in mind, like creating a hook named Any feedback in this issue will be highly appreciated. Thank you! |
Hi @Tainan404 and @TiagoJacobs 👋 I see that the relevant feature request apollographql/apollo-feature-requests#74 was closed by #6910. As you described, I am seeing deduplication of the initial subscriptions, but when subsequent components are rendered as you said I'm seeing new connections open. I suspect I know what's happening here: any existing deduplication is happening in the QueryManager when I'll have to dig into this more and discuss with the team, thanks for the reproduction! |
Hello @alessbell, To temporarily address this issue, we have implemented a new hook in BigBlueButton called I am sending it here in case it can be helpful to others. PS: Looking forward for an oficial fix in the future. Thanks again! |
Maybe same like this here? #10117 |
Hello @dominikklein - yes, it's the same case! |
When this would work in a better way, would it be the same for |
Issue Description
Intended outcome:
When multiple components subscribe for the same subscrition deduplicate them.
Actual outcome:
When a new component subscribes for an on running subscription it duplicates the request.
The first two components reuse the same request for subscriptions, the new one creates a new request for the same susbcription
example:
Screencast from 23-05-2024 18:54:27.webm
Link to Reproduction
https://github.com/Tainan404/subscription-duplication
Reproduction Steps
after start the server and client
@apollo/client
version3.10.4
The text was updated successfully, but these errors were encountered: