New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize `queueHasLockedRequests` to simplify RequestQueue v2 #2767

Open

janbuchar opened this issue Dec 6, 2024 · 0 comments · May be fixed by #2775

Assignees

Labels

t-tooling

Contributor

janbuchar commented Dec 6, 2024 •

edited

Loading

Flag added after discussion in misc(RequestQueueV2): adding notes for request queue v2 implementation #2700
It should allow us to simplify the isFinished logic - we don't need to do listAndLockHead + listHead + getRequest to find out if there are requests locked by other clients
We should not return true from isFinished if there are still batches being added in the background

The text was updated successfully, but these errors were encountered:

janbuchar added the t-tooling label

janbuchar self-assigned this

janbuchar linked a pull request

that will close this issue

fix: Simplified RequestQueueV2 implementation #2775

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment