Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing correct handling of 403 and the other codes that should trigger a SessionError #830

Open
Mantisus opened this issue Dec 18, 2024 · 0 comments
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@Mantisus
Copy link
Collaborator

Mantisus commented Dec 18, 2024

After #812, we discussed with @janbuchar that currently the trigger for SessionError based on status codes is not working correctly. To be more precise, when using the http client, it doesn't trigger at all.

There are several points that need to be clarified in this case:

  • Should blocked_status_codes in Session always take priority over any error status codes in BaseHttpClient and trigger session rotation instead of request retry?
  • Should additional_http_error_status_codes and ignore_http_error_status_codes be considered in the is_blocked_status_code method in Session, or should we only consider status codes defined in blocked_status_codes in Session?

Additionally: In PlaywrightCrawler, we have the opposite situation. Since we don't use an http client, we only have errors related to SessionError.

@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Dec 18, 2024
@Mantisus Mantisus added the bug Something isn't working. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

1 participant