Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow registering event handlers that do not accept any parameters #344

Open
janbuchar opened this issue Nov 27, 2024 · 1 comment · May be fixed by #354
Open

Allow registering event handlers that do not accept any parameters #344

janbuchar opened this issue Nov 27, 2024 · 1 comment · May be fixed by #354
Assignees
@janbuchar
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@janbuchar
Copy link
Contributor

Originally reported by @fnesveda in Slack

This ⬇️ should work, now it does not:

async def foo() -> None:
    print("Ding")

Actor.on(Event.bang, ding)
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 27, 2024
@fnesveda
Copy link
Member

Thanks Honza!

This was referenced Dec 10, 2024
Merged
Draft
janbuchar added a commit to apify/crawlee-python that referenced this issue Dec 16, 2024
@janbuchar @vdusek
feat: Expose event types, improve on/emit signature, allow parameterl…
c102c4c 
…ess listeners (#800)

- closes #561
- apify/apify-sdk-python#344

---------

Co-authored-by: Vlada Dusek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbuchar janbuchar

Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Better event listener type definitions apify/apify-sdk-python
2 participants
@janbuchar @fnesveda