Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.apify.com/sdk/ returns 404, docs.apify.com/sdk returns 200 #1102

Open
honzajavorek opened this issue Jul 19, 2024 · 2 comments
Open

docs.apify.com/sdk/ returns 404, docs.apify.com/sdk returns 200 #1102

honzajavorek opened this issue Jul 19, 2024 · 2 comments
Labels
t-docs Issues owned by technical writing team.

Comments

@honzajavorek
Copy link
Collaborator

When working on #1101 I found that:

  • curl -I https://docs.apify.com/sdk returns HTTP 200
  • curl -I https://docs.apify.com/sdk/ returns HTTP 404

I don't experience any issues in the browser, but link checks and possibly other tooling see the difference. I'd expect redirect, but not 404.

@honzajavorek honzajavorek added the t-docs Issues owned by technical writing team. label Jul 19, 2024
honzajavorek added a commit to honzajavorek/apify-docs that referenced this issue Jul 19, 2024
@B4nan
Copy link
Member

B4nan commented Jul 24, 2024

Duplicate of #520, its not that simple as you might think, and boils down to how docusaurus handles the trailing slash and the fact that there are more instances routes to the same domain.

@B4nan B4nan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
@B4nan
Copy link
Member

B4nan commented Jul 24, 2024

Oh wait, this is a bit different, you are talking about the new SDK landing page. But still, this is how docusaurus handles it I am afraid (and it is the case for every single "content" page, not just for the /sdk one), we set it up so there are no trailing slashes (with the exception of the child docusaurus instances, like https://docs.apify.com/sdk/js/ but we have 302 redirects there for the variant without trailing slash).

Maybe we could try to set the redirects up on nginx level, but it feels a bit scary since there are exceptions in the opposite direction (you want a redirect from /sdk/ to /sdk, but at the same time you want the opposite for /sdk/js, but again, not for anything nested like /sdk/js/docs). I'll leave this open.

@B4nan B4nan reopened this Jul 24, 2024
honzajavorek added a commit that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Issues owned by technical writing team.
Projects
None yet
Development

No branches or pull requests

2 participants