Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/address depth limitation of parseDateFields #522

Open
tobice opened this issue Feb 26, 2024 · 2 comments
Open

Remove/address depth limitation of parseDateFields #522

tobice opened this issue Feb 26, 2024 · 2 comments
Labels
backend Issues related to the platform backend. low priority Low priority issues to be done eventually. t-platform Issues with this label are in the ownership of the platform team. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@tobice
Copy link
Contributor

tobice commented Feb 26, 2024

parseDateFields traverses the provided JSON (used for Apify API responses) and converts certain fields to a Date object. The traversion depth has been historically limited to 3, possibly to avoid cyclic dependencies and improve performance on large responses.

This limitation is not communicated in any way, which might lead to weird surprises. We tried adding a log.warning but that led to log pollution as there are objects with arbitrary structure that went over the depth limit (most likely user data, data sets). Context here.

Possible solutions:

  • Remove the limitation
  • Stop parsing objects with arbitrary structure (user data, data sets)

Both are potential breaking changes.

This is currently not causing any issues and can be treated with low priority.

@tobice tobice added the t-platform Issues with this label are in the ownership of the platform team. label Feb 27, 2024
@drobnikj
Copy link
Member

Let's check with @B4nan, but I guess this is low-prio for now.

@drobnikj drobnikj added t-tooling Issues with this label are in the ownership of the tooling team. low priority Low priority issues to be done eventually. labels Feb 28, 2024
@B4nan
Copy link
Member

B4nan commented Feb 28, 2024

Yeah, this can wait, we just wanted to have this tracked. It sounds like a good first issue for some new joiners.

@fnesveda fnesveda added the backend Issues related to the platform backend. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues related to the platform backend. low priority Low priority issues to be done eventually. t-platform Issues with this label are in the ownership of the platform team. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

4 participants