Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serviceWeb() and serviceMail() from public API #190

Open
adamfranco opened this issue May 3, 2016 · 0 comments
Open

Remove serviceWeb() and serviceMail() from public API #190

adamfranco opened this issue May 3, 2016 · 0 comments
Milestone

Comments

@adamfranco
Copy link
Contributor

This is just a reminder of things we might want to do for a 2.0 release that already will have breaking changes in the API.

The getProxiedService() and initializeProxiedService() functions should be sufficient entry points for all proxy requests. Removing serviceWeb() and serviceMail() will reduce the number of ways to accomplish the same result, lowering the number of code-paths to test.

phpCAS::serviceWeb() and phpCAS::serviceMail() could be added to a backward-compatibility layer with a deprecation notice.

@adamfranco adamfranco added this to the 2.0.0 milestone May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant