You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
_send_msg_ams in its current implementation will not return a None under effectively any circumstance. A newline from a touch'd, empty file or some random 0's or more importantly the empty string will all render as "something", because only None can be None. We could try to handle this by handling for the empty string, making it return a None and not bother sending if the file itself has no characters bar newlines, but I'm reluctant to filter any more. After that, the if...else handling around 493 should work fine. Do you think that's worth implementing?
Following #247, I noticed that we're silently ignoring empty messages.
ssm/ssm/ssm2.py
Line 493 in 0ec0b31
_send_msg_ams
will returnNone
for an empty message and the code here will log as if the message was sent:ssm/ssm/ssm2.py
Line 495 in 0ec0b31
We should wrap that in an
if...else
and log a different message if the message wasn't sent, perhaps a warning.The text was updated successfully, but these errors were encountered: