-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add Selective backupType #8553
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8553 +/- ##
==========================================
- Coverage 60.58% 60.46% -0.12%
==========================================
Files 376 376
Lines 45679 45679
==========================================
- Hits 27673 27621 -52
- Misses 15424 15490 +66
+ Partials 2582 2568 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Where will the value be used? |
Database and table-level backups typically use parameters, using the concept of selective backup can make it easier for users to distinguish these backup methods from others. I will fix the usage of the value. |
I prefer not to add a new backup type as it doesn't affect the backup behavior. Users can set a specific backup name or add labels/annotations to distinguish backup methods. @ldming What's your opinion? |
if no specified backupType, how to set it? Full backups and continuous backups can be used together, these type is useful. |
fix #8475
ref #8472