Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Selective backupType #8553

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gnolong
Copy link
Contributor

@gnolong gnolong commented Nov 29, 2024

fix #8475
ref #8472

@gnolong gnolong requested review from ldming, wangyelei, zjx20 and a team as code owners November 29, 2024 06:27
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 29, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 29, 2024
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.46%. Comparing base (a68fb12) to head (4b605f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/dataprotection/restore/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8553      +/-   ##
==========================================
- Coverage   60.58%   60.46%   -0.12%     
==========================================
  Files         376      376              
  Lines       45679    45679              
==========================================
- Hits        27673    27621      -52     
- Misses      15424    15490      +66     
+ Partials     2582     2568      -14     
Flag Coverage Δ
unittests 60.46% <50.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjx20
Copy link
Contributor

zjx20 commented Nov 29, 2024

Where will the value be used?

@gnolong
Copy link
Contributor Author

gnolong commented Nov 29, 2024

Where will the value be used?

Database and table-level backups typically use parameters, using the concept of selective backup can make it easier for users to distinguish these backup methods from others. I will fix the usage of the value.

@zjx20
Copy link
Contributor

zjx20 commented Nov 29, 2024

I prefer not to add a new backup type as it doesn't affect the backup behavior. Users can set a specific backup name or add labels/annotations to distinguish backup methods.

@ldming What's your opinion?

@wangyelei
Copy link
Contributor

wangyelei commented Nov 29, 2024

I prefer not to add a new backup type as it doesn't affect the backup behavior. Users can set a specific backup name or add labels/annotations to distinguish backup methods.

@ldming What's your opinion?

if no specified backupType, how to set it? Full backups and continuous backups can be used together, these type is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] support backup and restore parameters to implement database and table-level backups
4 participants