-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support backup and restore parameters #8472
Merged
Merged
+1,373
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8472 +/- ##
==========================================
+ Coverage 60.55% 61.92% +1.36%
==========================================
Files 357 376 +19
Lines 42577 46626 +4049
==========================================
+ Hits 25784 28872 +3088
- Misses 14476 15206 +730
- Partials 2317 2548 +231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gnolong
requested review from
ldming,
wangyelei,
zjx20 and
a team
as code owners
November 18, 2024 07:42
wangyelei
reviewed
Nov 19, 2024
…ckup-restore-parameters
wangyelei
reviewed
Nov 26, 2024
wangyelei
approved these changes
Nov 26, 2024
ldming
reviewed
Nov 27, 2024
zjx20
reviewed
Nov 27, 2024
zjx20
approved these changes
Nov 29, 2024
wangyelei
pushed a commit
that referenced
this pull request
Nov 29, 2024
(cherry picked from commit a68fb12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8475
Backup and restore tools like
pg_dump
,pg_restore
,mysqldump
, etc., require various configuration parameters when performing database-level, schema-level, or table-level tasks, and these parameter structures differ among database engines. Therefore, we addparametersSchema
to theactionSet
API to define the schema of necessary configuration parameters, and addparameters
to thebackup
andrestore
API to pass parameter values to backup or restore workloads through environment variables.actionset API
The
actionset
API introduces theparametersSchema
structure to define the parameter schema for backup and restore tools. ThewithParameters
method specifies the parameters required for backup or restore operations.on-demand backup
A read-only
parameters
structure has been added underbackup.spec
in the backup API to pass configuration values defined byparametersSchema
.scheduled backup
The
schedulePolicy
structure needs to include aparameters
structure. The cron job created bybackupSchedule
will regularly execute on-demand backups with the correspondingparameters
structure. If multiple parameter configurations are needed, newschedulePolicy
entries with differentparameters
structures can be appended to theschedulePolicy
array. Additionally, aname
field has been added toschedulePolicy
to indicate different configurations.opsRequest API
The
opsRequest.spec.restore
andopsRequest.spec.backup
sections need to include aparameters
structure for generating the corresponding restore and backup.