diff --git a/superset/common/query_object.py b/superset/common/query_object.py index a45ffc560eaf5..235061a96d095 100644 --- a/superset/common/query_object.py +++ b/superset/common/query_object.py @@ -274,6 +274,8 @@ def validate( self._validate_no_have_duplicate_labels() # problematic line where calling sqlparser.parse() causes quadratic # performance for WHERE ... IN (...) clauses + # Clauses are anyway checked for their validity in + # e.g., connectors/sqla/models/get_query_str_extended # self._sanitize_filters() return None except QueryObjectValidationError as ex: diff --git a/superset/models/core.py b/superset/models/core.py index 3d64c97b42b9c..3b08e66eed6d1 100755 --- a/superset/models/core.py +++ b/superset/models/core.py @@ -556,7 +556,7 @@ def get_df( # pylint: disable=too-many-locals mutator: Callable[[pd.DataFrame], None] | None = None, ) -> pd.DataFrame: # before we split sqls using sql parse, however this core code is only reachable - # with single sql queries. Thus, we removed the engine spec parser + # with single sql queries. Thus, we remove the engine spec parser here # sqls = self.db_engine_spec.parse_sql(sql) with self.get_sqla_engine_with_context(schema) as engine: