Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokio I/O impl for FuturesAsyncRead #4872

Open
sameer opened this issue Jul 8, 2024 · 1 comment
Open

Tokio I/O impl for FuturesAsyncRead #4872

sameer opened this issue Jul 8, 2024 · 1 comment

Comments

@sameer
Copy link
Contributor

sameer commented Jul 8, 2024

Hello,

In 0.46.0 onwards, the read traits were removed from Reader and pushed into methods like into_futures_async_read and read. However, support for the Tokio I/O traits was lost in the process.

Is there any interest in supporting these with feature gating? For now I've been using async-compat to work around this.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 9, 2024

There is a plan to implement into_tokio_async_read() -> TokioAsyncReader. However, I am not confident that adding a feature gate at the Reader level is a good idea.

Since there is a workaround for this, how about we leave this issue open to collect more feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants