Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: Move root out of backend to operator instead #4774

Open
Xuanwo opened this issue Jun 20, 2024 · 2 comments
Open

idea: Move root out of backend to operator instead #4774

Xuanwo opened this issue Jun 20, 2024 · 2 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jun 20, 2024

Every services need to handle root, which most of the time is duplicated. Maybe we can move root of backend and handling at operato level?

Benefits:

  • Operator can implement something like cd/change_root so users don't need to build a new one.
  • Services don't need to handle root logic again and again.

Most services should work smoothly, but we need to handle Windows paths carefully, as they will require a format like C:\\path\\to\\data.

@yuchanns
Copy link
Member

IMO it is better to build an absolute path at the operator level and pass it to the service backends. It delivers a clear path which may reduce path-related bugs when implementing a backend.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 20, 2024

IMO it is better to build an absolute path at the operator level and pass it to the service backends. It delivers a clear path which may reduce path-related bugs when implementing a backend.

That's exactly what this idea want to address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants