Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issues of integration unftp-sbe #4769

Open
4 tasks
Xuanwo opened this issue Jun 19, 2024 · 9 comments
Open
4 tasks

Tracking issues of integration unftp-sbe #4769

Xuanwo opened this issue Jun 19, 2024 · 9 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jun 19, 2024

#4765 has added most features around unftp-sbe, this issue is used to track the remaining issues.

Tasks

  • Add README for this project
  • Add basic example for this project
  • Setup CI for unftp-sbe
  • Remove Cargo.lock file
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 19, 2024

cc @George-Miao, would you like to take a look?

@George-Miao
Copy link
Contributor

Sure. I'll add the README and examples.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 19, 2024

Sure. I'll add the README and examples.

Thanks a lot!

@George-Miao
Copy link
Contributor

How should the CI part be done? @Xuanwo

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 25, 2024

How should the CI part be done? @Xuanwo

We can setup some basic CI first like clippy and tests

@George-Miao
Copy link
Contributor

All tasks have been done. Should we close the issue?

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 26, 2024

Hi, do you think it's a good idea to add some tests for ubftp-sbe integration like https://github.com/bolcom/libunftp/tree/master/crates/unftp-sbe-gcs/tests? I feel like we can at least test it with fs, s3, gcs and azblob.

You can finish the tests part and I'm willing to get it ready in our workflow.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 27, 2024

I'm happy that unftp upstream is gooding to use this integration directly: bolcom/unFTP#183

Before we start the work at upstream side, how about finishing the test work first? I want to avoid the unexpected issues at upstream.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 1, 2024

Current docs for unftp-sbe-opendal doesn't look good

image

Would you like to track it in a new issue or in this tracking issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants