From a745b3c640ca3d98260bd98e78ae8ed4fc13fc70 Mon Sep 17 00:00:00 2001 From: "markrmiller@gmail.com" Date: Tue, 14 Jul 2020 14:33:31 -0500 Subject: [PATCH] #154 - Change SPI reload default. --- .../src/java/org/apache/solr/core/SolrResourceLoader.java | 2 +- .../test-framework/src/java/org/apache/solr/SolrTestCase.java | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java b/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java index ac170aebdab1..64572750d8c6 100644 --- a/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java +++ b/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java @@ -238,7 +238,7 @@ synchronized void addToClassLoader(List urls) { * and before using this ResourceLoader. */ synchronized void reloadLuceneSPI() { - if (Boolean.getBoolean("solr.skipReloadSPI")) { + if (!Boolean.getBoolean("solr.reloadSPI")) { return; } diff --git a/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java b/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java index 6312e149bb87..5c7070adad55 100644 --- a/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java +++ b/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java @@ -187,7 +187,9 @@ public static void setDefaultConfigDirSysPropIfNotSet() throws Exception { // can make things quite slow System.setProperty("solr.disableJmxReporter", "true"); System.setProperty("solr.skipCommitOnClose", "true"); - System.setProperty("solr.skipReloadSPI", "true"); // can generate tons of URL garbage and can happen too often + + // can generate tons of URL garbage and can happen too often, defaults to false now anyway + System.setProperty("solr.reloadSPI", "false"); // nocommit - not used again yet System.setProperty("solr.OverseerStateUpdateDelay", "0");