[#5442] Improvement(iceberg-common): Overwrite the equals and hashCode methods to avoid frequently creating HiveClientPool instances #5443
Conversation
When Impersonation is disabled, we use a super user to access hms, reusing the clients are reasonable. When Impersonation is enabled , we get a HiveClientPool instance from the clientPoolCache through a Now each request will create a HiveClientPool instance, the HiveClientPool is meaningless. Is my understanding correct? If there is any problem, please help point out. Thank you very much cc @yuqi1129 |
| @@ -107,7 +112,13 @@ public IcebergHiveCachedClientPool(Configuration conf, Map<String, String> prope | |||
| @VisibleForTesting | |||
| HiveClientPool clientPool() { | |||
| Key key = extractKey(properties.get(CatalogProperties.CLIENT_POOL_CACHE_KEYS), conf); | |||
There was a problem hiding this comment.
when the Impersonation is enabled , the CatalogProperties.CLIENT_POOL_CACHE_KEYS should not be null and must cantain ugi or user_name to avoid diffrent users reusing a same HiveClientPool instance.
There was a problem hiding this comment.
I see. Thanks for the explanation.
What changes were proposed in this pull request?
Overwrite the equals and hashCode methods to avoid frequently creating HiveClientPool instances
Why are the changes needed?
Fix: #5442
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UT.