Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] aws-sdk compile error makes build doris from scratch failed #20665

Closed
2 of 3 tasks
zhiqiang-hhhh opened this issue Jun 10, 2023 · 4 comments
Closed
2 of 3 tasks

Comments

@zhiqiang-hhhh
Copy link
Contributor

zhiqiang-hhhh commented Jun 10, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Version

doris master, commit id 44e20d9

What's Wrong?

when building doris through build.sh, meet cmake error like:

CMake Error at CMakeLists.txt:185 (include):
  include could not find requested file:

    AwsFindPackage


CMake Error at CMakeLists.txt:197 (add_subdirectory):
  add_subdirectory given source "crt/aws-crt-cpp" which is not an existing
  directory.
...

CMake Error at aws-cpp-sdk-core/CMakeLists.txt:516 (aws_use_package):
  Unknown CMake command "aws_use_package".

What You Expected?

should build succeed

How to Reproduce?

Just download doris to a new Linux environment, and run build.sh, this error should be reproduced.

A more direct way:

  1. rm -rf thirdparty/src/aws-sdk-cpp-1.9.272/
  2. cd thirdyparty
  3. sh build-thirdparty.sh -j 99 --continue aws_sdk

Anything Else?

The reason is that prefetch_crt_dependency.sh of aws-skd tar.gz file will download outdated deps of aws-skd, which make cmake file not work.

See details: aws/aws-sdk-cpp#1648

Possible solution:

  1. do not clone .tar.gz of aws-sdk, use git clone git clone --recurse-submodules --branch 1.9.272 instead
  2. upgrade aws-sdk from 1.9.x to 1.10.x, which fixed compile problem in Improvement to build, install, and distribution mechanisms aws/aws-sdk-cpp#1888

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@adonis0147
Copy link
Contributor

adonis0147 commented Jun 12, 2023

Hi @zhiqiang-hhhh, I think the solution #2 is better than #1.

@zhiqiang-hhhh
Copy link
Contributor Author

I have tried to reproduce the compile error, but failed.

Closed.

@hzjhjjyy
Copy link

I also encountered this problem when building, and finally running the prefetch_crt_dependency.sh script manually after the aws-sdk-cpp was unpacked during the build, and then solved the problem.

@HackToday
Copy link
Contributor

This can happens with curl download with certificates issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants