Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the prompt types - "password" and "number". #113

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

laelbe
Copy link

@laelbe laelbe commented Oct 22, 2018

Platforms affected

iOS, Android, Windows.

What does this PR do?

Implemented the prompt types - "password" and "number".

What testing has been done on this change?

Tested on some iOS and Android devices.
No tests were performed on Windows.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@laelbe
Copy link
Author

laelbe commented Oct 22, 2018

Preview

IOS

IOS Preview

Android

Android Preview

@janpio
Copy link
Member

janpio commented Oct 30, 2018

number is an interesting addition, I am not too sure about password as it could give the user a wrong impression on who can see the data etc. On the other side, a malicious developer of course could just create a custom plugin implementing the same, so there's no real reason why not to include this here as well.

travis tests are failing because of:

/home/travis/build/apache/cordova-plugin-dialogs/www/notification.js
  90:52  error  Expected '===' and instead saw '=='  eqeqeq

@janpio janpio added the feature label Oct 30, 2018
README.md Outdated Show resolved Hide resolved
@mkurzweil
Copy link

mkurzweil commented Jul 17, 2019

Hi,

I changed the Notification.java (src/android/Notification.java) file and after that the prompt doesn't show anymore --> I've tested it on an Android device (API 28)

Can someone help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants