Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cordova-plugin-test-framework takes a long time #239

Open
hudson-pierce opened this issue Jul 26, 2022 · 1 comment · May be fixed by #243
Open

Adding cordova-plugin-test-framework takes a long time #239

hudson-pierce opened this issue Jul 26, 2022 · 1 comment · May be fixed by #243

Comments

@hudson-pierce
Copy link

hudson-pierce commented Jul 26, 2022

It takes approximately 10 minutes for the cordova plugin add github:apache/cordova-plugin-test-framework --no-telemetry --no-update-notifier step to finish...

On my local machine I pulled down the cordova-paramedic project and in lib/ParamedicApp.js at line 73 I replaced:

const additionalPlugins = ['github:apache/cordova-plugin-test-framework', path.join(__dirname, '..', 'paramedic-plugin')];

with:

const additionalPlugins = ['git+https://github.com/apache/cordova-plugin-test-framework.git', path.join(__dirname, '..', 'paramedic-plugin')];

Now the plugin is added very quickly. Could we please make this change?

@breautek
Copy link
Contributor

breautek commented Oct 1, 2022

github:apache/cordova-plugin-test-framework should just translate to git+https://github.com/apache/cordova-plugin-test-framework.git (by npm)

Is this reproducible? Are you sure this isn't a one off network issue? For the record, cordova plugin add github:apache/cordova-plugin-test-framework --no-telemetry --no-update-notifier took less than second to resolve for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants