Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::Make() #44810

Open
raulcd opened this issue Nov 22, 2024 · 5 comments
Open

Comments

@raulcd
Copy link
Member

raulcd commented Nov 22, 2024

Describe the enhancement requested

The current version uses arrow::Status and std::unique_ptr<FileReader>*:

static ::arrow::Status Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
const ArrowReaderProperties& properties,
std::unique_ptr<FileReader>* out);
/// Factory function to create a FileReader from a ParquetFileReader
static ::arrow::Status Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
std::unique_ptr<FileReader>* out);

Component(s)

C++, Parquet

@raulcd
Copy link
Member Author

raulcd commented Nov 22, 2024

@kou @pitrou from my understanding those are things that we want to keep doing and migrating to ::arrow::Result, right? I could do some of those :)

@pitrou
Copy link
Member

pitrou commented Nov 22, 2024

Yes, we might have let slip a couple of them.

You could definitely do some of those, but it could also be an easy task for a first-time contributor.

@malinjawi
Copy link
Contributor

Hey @raulcd @pitrou I would be happy to work on this issue. I just got my first PR merged and happy to continue making contributions to Arrow.

@raulcd
Copy link
Member Author

raulcd commented Nov 22, 2024

Thanks @malinjawi for your contributions!

@malinjawi
Copy link
Contributor

Hey @raulcd @pitrou thanks for raising this issue. I have raised a PR and addressed other related changes found with the current versions of arrow::Status and std::unique_ptr<FileReader>*. Please let me know i there are anything else I can address to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants