Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Add top-level .editorconfig for C++, Python... #44805

Open
pitrou opened this issue Nov 21, 2024 · 5 comments
Open

[Dev] Add top-level .editorconfig for C++, Python... #44805

pitrou opened this issue Nov 21, 2024 · 5 comments

Comments

@pitrou
Copy link
Member

pitrou commented Nov 21, 2024

Describe the enhancement requested

See https://editorconfig.org/

Some languages such as Python, C++, bash... are used in various parts of our repository, a top-level .editorconfig would help maintain a consistent style at least for the basics (such as indentation).

Component(s)

C++, Developer Tools, Python

@pitrou
Copy link
Member Author

pitrou commented Nov 21, 2024

Thoughts @kou @raulcd @assignUser ?

@kou
Copy link
Member

kou commented Nov 22, 2024

I'm OK with this but I don't want to maintain .editorconfig too much to align with our clang-format configuration.

If we have .editorconfig, we can remove **/.dir-locals.el added by me. :-)

@kou
Copy link
Member

kou commented Nov 22, 2024

We should check our style by pre-commit even if we have .editorconfig.

@pitrou
Copy link
Member Author

pitrou commented Nov 22, 2024

The EditorConfig spec is extremely basic for now, it mostly only covers indentation and line endings. But it would help working on multiple projects with different indentation settings.

@assignUser
Copy link
Member

It seems pretty unintrusive and useful 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants