Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help request: Alternatives to Semantic Pull Requests #7164

Closed
tao12345666333 opened this issue May 30, 2022 · 12 comments · Fixed by #7457
Closed

help request: Alternatives to Semantic Pull Requests #7164

tao12345666333 opened this issue May 30, 2022 · 12 comments · Fixed by #7457
Labels
good first issue Good for newcomers

Comments

@tao12345666333
Copy link
Member

tao12345666333 commented May 30, 2022

Description

Currently we are using Semantic Pull Requests to check in PR but the project is no longer maintained. we need some alternatives.

e.g.

If anyone is interested in this, please submit a PR to complete this replacement

@kwanhur
Copy link
Contributor

kwanhur commented Jun 2, 2022

Note it:

We only allow Actions that are official "Made by GitHub" or local to the Apache org on GitHub, to address a potential security vulnerability. This is an incident-related policy change. We are researching the situation, and the policy may evolve based on what we learn.

https://infra.apache.org/github-actions-secrets.html

@tokers
Copy link
Contributor

tokers commented Jun 2, 2022

May use git submodule to do this.

@tao12345666333
Copy link
Member Author

May use git submodule to do this.

Right!

@tao12345666333 tao12345666333 added the good first issue Good for newcomers label Jun 2, 2022
@ccxhwmy
Copy link
Contributor

ccxhwmy commented Jul 10, 2022

May use git submodule to do this.

Right!

I can understand the need to replace semantic-pull-request with action-semantic-pull-request, but why use git submodule?

@tao12345666333
Copy link
Member Author

@ccxhwmy ref: https://infra.apache.org/github-actions-secrets.html

@kwanhur
Copy link
Contributor

kwanhur commented Jul 11, 2022

Personally, Github Workflow job better than submodule, just like Lint

@ccxhwmy
Copy link
Contributor

ccxhwmy commented Jul 14, 2022

Personally, Github Workflow job better than submodule, just like Lint

Does you mean, do git clone in github workflows instead of git submoudle

@tao12345666333
Copy link
Member Author

@ccxhwmy submodle is more suitable.

@ccxhwmy
Copy link
Contributor

ccxhwmy commented Jul 15, 2022

@ccxhwmy submodle is more suitable.

I found that doing git clone in the github workflows still works, Would you tell me why git submodule is more suitable? I want to learn more about it.

@ccxhwmy
Copy link
Contributor

ccxhwmy commented Jul 18, 2022

I found that action-semantic-pull-request does not support the characteristic "allowRevertCommit" which semantic-pull-request support, is there some mistake in my understanding?

@spacewander
Copy link
Member

amannn/action-semantic-pull-request#192
I see you have opened an issue for it.
If the action doesn't support it, we can omit it for now.

@ccxhwmy
Copy link
Contributor

ccxhwmy commented Jul 18, 2022

amannn/action-semantic-pull-request#192 I see you have opened an issue for it. If the action doesn't support it, we can omit it for now.

ok~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants