Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Task retries in Task SDK #44351

Closed
kaxil opened this issue Nov 25, 2024 · 0 comments · Fixed by #45106
Closed

Handle Task retries in Task SDK #44351

kaxil opened this issue Nov 25, 2024 · 0 comments · Fixed by #45106
Assignees
@amoghrajesh
Labels
area:core area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK

Comments

@kaxil
Copy link
Member

kaxil commented Nov 25, 2024 •
edited
Loading

Follow-up of #44241 to handle Task retries i.e. checking max retries, setting correct state etc
@kaxil kaxil added the area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK label Nov 25, 2024
@kaxil kaxil changed the title Handle Task retries (State.UP_FOR_RETRY) in Task SDK Handle Task retries in Task SDK Nov 25, 2024
@dosubot dosubot bot added the area:core label Nov 25, 2024
@amoghrajesh amoghrajesh mentioned this issue Dec 16, 2024
Merged
kaxil pushed a commit that referenced this issue Dec 18, 2024
@amoghrajesh
AIP-72: Handling failed TI state for AirflowFailException & `Airf…
cfc2157 
…lowSensorTimeout` (#44954)

related: #44414

We already have support for handling terminal states from the task execution side as well as the task SDK client side. (almost) and failed state is part of the terminal state.

This PR extends the task runner's run function to handle cases when we have to fail a task: `AirflowFailException, AirflowSensorTimeout`. It is functionally very similar to #44786

As part of failing a task, multiple other things also needs to be done like:
- Callbacks: which will eventually be converted to teardown tasks
- Retries: Handled in #44351
- unmapping TIs: #44351
- Handling task history: will be handled by #44952
- Handling downstream tasks and non teardown tasks: will be handled by #44951

### Testing performed
#### End to End with Postman

1. Run airflow with breeze and run any DAG
![image](https://github.com/user-attachments/assets/fafc89ea-4e28-4802-912b-d72bf401d94b)

2. Login to metadata DB and get the "id" for your task instance from TI table
![image](https://github.com/user-attachments/assets/75440f0f-f62a-4277-a2e6-cb78bd666dd4)

3. Send a request to `fail` your task
![image](https://github.com/user-attachments/assets/5991e944-f416-4b79-9954-15f1a6ebdd79)

Or using curl:
```
curl --location --request PATCH 'http://localhost:29091/execution/task-instances/0193cec2-f46b-7348-9c27-9869d835dc7b/state' \
--header 'Content-Type: application/json' \
--data '{
    "state": "failed",
    "end_date": "2024-10-31T12:00:00Z"
}'
```

4. Refresh back the Airflow UI to see that the task is in failed state.
![image](https://github.com/user-attachments/assets/bb866dc6-e1d6-435e-abe4-2d04c97280ad)
@amoghrajesh amoghrajesh mentioned this issue Dec 20, 2024
Merged
3 tasks
kaxil pushed a commit to astronomer/airflow that referenced this issue Dec 27, 2024
@amoghrajesh @kaxil
AIP-72: Handling task retries in task SDK + execution API
ff1c5b3 
closes: apache#44351
kaxil pushed a commit to astronomer/airflow that referenced this issue Dec 27, 2024
@amoghrajesh @kaxil
AIP-72: Handling task retries in task SDK + execution API
5858fc6 
closes: apache#44351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amoghrajesh amoghrajesh

Labels
area:core area:task-execution-interface-aip72 AIP-72: Task Execution Interface (TEI) aka Task SDK
Projects
AIP-72 - Task Execution Interface and SDK
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AIP-72: Handling task retries in task SDK + execution API astronomer/airflow
2 participants
@kaxil @amoghrajesh