Narrow the files checked by compaction commit #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the conditional mutation to commit a compaction would require all files in the tablet be the same as read earlier and on a busy tablet this could fail and retry often. The check has now been narrowed to only verify that the files involved with the compaction still exist. A new method was added to Ample called requireFiles(Set<StoredTabletFile> files) which creates a condition for each file column to verify each one exists. This closes apache#5117
keith-turner
added a commit
to keith-turner/accumulo
that referenced
this pull request
Dec 9, 2024
Using the new method added in apache#5153 the set of files checked in the conditional mutation for compacaction reserervation was reduced from all tablet files to only the files in the compaction job. Noticed the conditinal mutation was not checking the user compaction requested field while making this change and added it.
keith-turner
added a commit
that referenced
this pull request
Dec 11, 2024
) Using the new method added in #5153 the set of files checked in the conditional mutation for compacaction reserervation was reduced from all tablet files to only the files in the compaction job. Noticed the conditinal mutation was not checking the user compaction requested field while making this change and added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the conditional mutation to commit a compaction would require all files in the tablet be the same as read earlier and on a busy tablet this could fail and retry often. The check has now been narrowed to only verify that the files involved with the compaction still exist. A new method was added to Ample called requireFiles(Set files) which creates a condition for each file column to verify each one exists.
This closes #5117